diff options
authorAlessio Igor Bogani <abogani@kernel.org>2011-05-18 22:35:59 +0200
committerRusty Russell <rusty@rustcorp.com.au>2011-05-19 16:55:27 +0930
commit9d63487f86115b1d3ef69670043bcf2b83c4d227 (patch)
parent403ed27846aa126ecf0b842b5b179c506b9d989c (diff)
module: Use binary search in lookup_symbol()
The function is_exported() with its helper function lookup_symbol() are used to verify if a provided symbol is effectively exported by the kernel or by the modules. Now that both have their symbols sorted we can replace a linear search with a binary search which provide a considerably speed-up. This work was supported by a hardware donation from the CE Linux Forum. Signed-off-by: Alessio Igor Bogani <abogani@kernel.org> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 files changed, 2 insertions, 5 deletions
diff --git a/kernel/module.c b/kernel/module.c
index d1db8eb56ad4..22879725678d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2055,11 +2055,8 @@ static const struct kernel_symbol *lookup_symbol(const char *name,
const struct kernel_symbol *start,
const struct kernel_symbol *stop)
- const struct kernel_symbol *ks = start;
- for (; ks < stop; ks++)
- if (strcmp(ks->name, name) == 0)
- return ks;
- return NULL;
+ return bsearch(name, start, stop - start,
+ sizeof(struct kernel_symbol), cmp_name);
static int is_exported(const char *name, unsigned long value,

Privacy Policy