|author||Sam Ravnborg <firstname.lastname@example.org>||2007-12-06 22:20:11 +0100|
|committer||Sam Ravnborg <email@example.com>||2007-12-09 08:43:42 +0100|
kbuild: fix building with redirected output.
Jan Altenberg <firstname.lastname@example.org> reported that building with redirected input like this failed: make O=dir oldconfig bzImage < /dev/null The problem were caused by a make silentoldconfig being run before oldconfig and with a non-recent .config the build failed because silentoldconfig requires non-redirected stdin. Silentoldconfig was run as a side-effect of having the top-level Makefile re-made by make. Introducing an empty rule for the top-level Makefile (and Kbuild.include) fixed the issue. Signed-off-by: Sam Ravnborg <email@example.com>
Diffstat (limited to 'Makefile')
1 files changed, 6 insertions, 5 deletions
@@ -108,6 +108,9 @@ endif
PHONY := _all
+# Cancel implicit rules on top Makefile
+$(CURDIR)/Makefile Makefile: ;
# Invoke a second make in the output directory, passing relevant variables
# check that the output directory actually exists
@@ -121,7 +124,7 @@ $(if $(filter-out $(KBUILD_OUTPUT),$(shell /bin/pwd)),, \
PHONY += $(MAKECMDGOALS) sub-make
-$(filter-out _all sub-make,$(MAKECMDGOALS)) _all: sub-make
+$(filter-out _all sub-make $(CURDIR)/Makefile, $(MAKECMDGOALS)) _all: sub-make
@@ -291,7 +294,8 @@ export quiet Q KBUILD_VERBOSE
# Look for make include files relative to root of kernel src
MAKEFLAGS += --include-dir=$(srctree)
-# We need some generic definitions.
+# We need some generic definitions (do not try to remake the file).
# Make variables (CC, etc...)
@@ -1560,9 +1564,6 @@ endif # skip-makefile
PHONY += FORCE
-# Cancel implicit rules on top Makefile, `-rR' will apply to sub-makes.
# Declare the contents of the .PHONY variable as phony. We keep that
# information in a variable se we can use it in if_changed and friends.