path: root/drivers/base/driver.c
diff options
authorJames Bottomley <James.Bottomley@HansenPartnership.com>2005-09-06 16:56:51 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-09-07 18:26:54 -0700
commit34bb61f9ddabd7a7f909cbfb05592eb775f6662a (patch)
tree06232f6fc975bd279236fd8005c7d5528220ec68 /drivers/base/driver.c
parentdf4edad1787bbfa3c9c10824e4f11e9f4a7ec5c6 (diff)
[PATCH] fix klist semantics for lists which have elements removed on traversal
The problem is that klists claim to provide semantics for safe traversal of lists which are being modified. The failure case is when traversal of a list causes element removal (a fairly common case). The issue is that although the list node is refcounted, if it is embedded in an object (which is universally the case), then the object will be freed regardless of the klist refcount leading to slab corruption because the klist iterator refers to the prior element to get the next. The solution is to make the klist take and release references to the embedding object meaning that the embedding object won't be released until the list relinquishes the reference to it. (akpm: fast-track this because it's needed for the 2.6.13 scsi merge) Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/base/driver.c')
1 files changed, 14 insertions, 1 deletions
diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 291c5954a3af..ef3fe513e398 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -142,6 +142,19 @@ void put_driver(struct device_driver * drv)
+static void klist_devices_get(struct klist_node *n)
+ struct device *dev = container_of(n, struct device, knode_driver);
+ get_device(dev);
+static void klist_devices_put(struct klist_node *n)
+ struct device *dev = container_of(n, struct device, knode_driver);
+ put_device(dev);
* driver_register - register driver with bus
@@ -157,7 +170,7 @@ void put_driver(struct device_driver * drv)
int driver_register(struct device_driver * drv)
- klist_init(&drv->klist_devices);
+ klist_init(&drv->klist_devices, klist_devices_get, klist_devices_put);
return bus_add_driver(drv);

Privacy Policy