path: root/drivers/firewire/ohci.c
diff options
authorLinus Torvalds <torvalds@linux-foundation.org>2010-08-29 08:19:02 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-08-29 08:19:02 -0700
commit994b384a040d6f8afc3595c1a99c1b784e0cce49 (patch)
treef7fb9b63f5a68a13bc6fbd160eba91b0c865b487 /drivers/firewire/ohci.c
parent29cfcddc0e745b515ec360ffe2ee4e7a4015efd8 (diff)
parenta4dc090b6cb445257d2a8e44f85395ced6d1ed3e (diff)
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6: firewire: ohci: work around VIA and NEC PHY packet reception bug firewire: core: do not use del_timer_sync() in interrupt context firewire: net: fix unicast reception RCODE in failure paths firewire: sbp2: fix stall with "Unsolicited response" firewire: sbp2: fix memory leak in sbp2_cancel_orbs or at send error ieee1394: Adjust confusing if indentation
Diffstat (limited to 'drivers/firewire/ohci.c')
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
index 7f03540cabe8..be29b0bb2471 100644
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -694,7 +694,15 @@ static __le32 *handle_ar_packet(struct ar_context *ctx, __le32 *buffer)
log_ar_at_event('R', p.speed, p.header, evt);
- * The OHCI bus reset handler synthesizes a phy packet with
+ * Several controllers, notably from NEC and VIA, forget to
+ * write ack_complete status at PHY packet reception.
+ */
+ if (evt == OHCI1394_evt_no_status &&
+ (p.header[0] & 0xff) == (OHCI1394_phy_tcode << 4))
+ p.ack = ACK_COMPLETE;
+ /*
+ * The OHCI bus reset handler synthesizes a PHY packet with
* the new generation number when a bus reset happens (see
* section This helps us determine when a request
* was received and make sure we send the response in the same

Privacy Policy