path: root/drivers/infiniband/core/uverbs_main.c
diff options
authorGoldwyn Rodrigues <rgoldwyn@suse.de>2011-07-04 09:26:57 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2011-07-04 15:53:28 -0700
commitb2bc4782191cb574924a1d09f48083ea8b33a93b (patch)
treee91ef7b6fb2869908ce1aa7372747687ad0b5ec3 /drivers/infiniband/core/uverbs_main.c
parentba466c74d99b91b2f390a09ad31bbc6cddd8cf4b (diff)
RDMA: Check for NULL mode in .devnode methods
Commits 71c29bd5c235 ("IB/uverbs: Add devnode method to set path/mode") and c3af0980ce01 ("IB: Add devnode methods to cm_class and umad_class") added devnode methods that set the mode. However, these methods don't check for a NULL mode, and so we get a crash when unloading modules because devtmpfs_delete_node() calls device_get_devnode() with mode == NULL. Add the missing checks. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de> [ Also fix cm.c. - Roland ] Signed-off-by: Roland Dreier <roland@purestorage.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/infiniband/core/uverbs_main.c')
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c
index e49a85f8a44d..56898b6578a4 100644
--- a/drivers/infiniband/core/uverbs_main.c
+++ b/drivers/infiniband/core/uverbs_main.c
@@ -826,7 +826,8 @@ static void ib_uverbs_remove_one(struct ib_device *device)
static char *uverbs_devnode(struct device *dev, mode_t *mode)
- *mode = 0666;
+ if (mode)
+ *mode = 0666;
return kasprintf(GFP_KERNEL, "infiniband/%s", dev_name(dev));

Privacy Policy