path: root/lib/smp_processor_id.c
diff options
authorSteven Rostedt <srostedt@redhat.com>2008-05-12 19:20:44 (GMT)
committerThomas Gleixner <tglx@linutronix.de>2008-05-23 18:39:17 (GMT)
commit5568b139f4d196273958ae2947a736fdf1ffeece (patch)
tree27b9b64c33b970e0d2608324bc615382953fb705 /lib/smp_processor_id.c
parentf43fdad8627fec2d21df92799b254dceb66c9c3c (diff)
ftrace: debug smp_processor_id, use notrace preempt disable
The debug smp_processor_id caused a recursive fault in debugging the irqsoff tracer. The tracer used a smp_processor_id in the ftrace callback, and this function called preempt_disable which also is traced. This caused a recursive fault (stack overload). Since using smp_processor_id without debugging on does not cause faults with the tracer (even when the tracer is wrong), the debug version should not cause a system reboot. This changes the debug_smp_processor_id to use the notrace versions of preempt_disable and enable. Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'lib/smp_processor_id.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c
index e555ab6..3b4dc09 100644
--- a/lib/smp_processor_id.c
+++ b/lib/smp_processor_id.c
@@ -37,7 +37,7 @@ notrace unsigned int debug_smp_processor_id(void)
* Avoid recursion:
- preempt_disable();
+ preempt_disable_notrace();
if (!printk_ratelimit())
goto out_enable;
@@ -49,7 +49,7 @@ notrace unsigned int debug_smp_processor_id(void)
- preempt_enable_no_resched();
+ preempt_enable_no_resched_notrace();
return this_cpu;

Privacy Policy