path: root/drivers/gpu
diff options
authorLyude Paul <lyude@redhat.com>2018-12-11 18:56:20 -0500
committerBen Skeggs <bskeggs@redhat.com>2018-12-12 17:00:26 +1000
commit24199c5436f267399afed0c4f1f57663c0408f57 (patch)
treef4811083920d7453c39f9f192023400c8dc1956d /drivers/gpu
parent970a5ee41c72df46e3b0f307528c7d8ef7734a2e (diff)
drm/nouveau/kms: Fix memory leak in nv50_mstm_del()
Noticed this while working on redoing the reference counting scheme in the DP MST helpers. Nouveau doesn't attempt to call drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports. Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream") Signed-off-by: Lyude Paul <lyude@redhat.com> Cc: <stable@vger.kernel.org> # v4.10+ Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/gpu')
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 03e3ce9e6f28..b7fc471056ad 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1264,6 +1264,7 @@ nv50_mstm_del(struct nv50_mstm **pmstm)
struct nv50_mstm *mstm = *pmstm;
if (mstm) {
+ drm_dp_mst_topology_mgr_destroy(&mstm->mgr);
*pmstm = NULL;

Privacy Policy