aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/leds/leds-gpio-register.c
diff options
context:
space:
mode:
authorXiubo Li <Li.Xiubo@freescale.com>2014-09-28 08:57:15 (GMT)
committerBryan Wu <cooloney@gmail.com>2014-09-29 17:21:01 (GMT)
commita823e76138466225d0a9f45520c5654132939a01 (patch)
tree9c0bce385e1ec06bc173502fd59fb7a7df89b6b3 /drivers/leds/leds-gpio-register.c
parent4cc72346f05ef549403d997d66fd517109e59d24 (diff)
led: gpio: Fix possible ZERO_SIZE_PTR pointer dereferencing error.
Since we cannot make sure the 'pdata->num_leds' will always be none zero here, and then if it equals to zero, the kmemdup() will return ZERO_SIZE_PTR, which equals to ((void *)16). So this patch fix this with just doing the zero check before calling kmemdup(). Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers/leds/leds-gpio-register.c')
-rw-r--r--drivers/leds/leds-gpio-register.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c
index fbd8934..75717ba 100644
--- a/drivers/leds/leds-gpio-register.c
+++ b/drivers/leds/leds-gpio-register.c
@@ -28,6 +28,9 @@ struct platform_device *__init gpio_led_register_device(
struct platform_device *ret;
struct gpio_led_platform_data _pdata = *pdata;
+ if (!pdata->num_leds)
+ return ERR_PTR(-EINVAL);
+
_pdata.leds = kmemdup(pdata->leds,
pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL);
if (!_pdata.leds)

Privacy Policy