path: root/drivers
diff options
authorLinus Torvalds <torvalds@linux-foundation.org>2011-10-17 08:24:24 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2011-10-17 08:24:24 -0700
commita84a79e4d369a73c0130b5858199e949432da4c6 (patch)
treee88e57ce951eeaf2780a27787ad712a09eb8be7e /drivers
parent8bc03e8f3a334e09e89a7dffb486ee97a5ce84ae (diff)
Avoid using variable-length arrays in kernel/sys.c
The size is always valid, but variable-length arrays generate worse code for no good reason (unless the function happens to be inlined and the compiler sees the length for the simple constant it is). Also, there seems to be some code generation problem on POWER, where Henrik Bakken reports that register r28 can get corrupted under some subtle circumstances (interrupt happening at the wrong time?). That all indicates some seriously broken compiler issues, but since variable length arrays are bad regardless, there's little point in trying to chase it down. "Just don't do that, then". Reported-by: Henrik Grindal Bakken <henribak@cisco.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions

Privacy Policy