path: root/drivers
diff options
authorAlexander Duyck <alexander.h.duyck@linux.intel.com>2018-10-10 16:39:06 -0700
committerDan Williams <dan.j.williams@intel.com>2018-10-12 08:39:15 -0700
commit19418b024427ec60ba6084addf691a8d93670398 (patch)
treea92739838e0700bb092d595c29e1acbb5f583a90 /drivers
parent1cfeb66e8e137be8e01b88bb4d416e987abda4a4 (diff)
nvdimm: Remove empty if statement
This patch removes an empty statement from an if expression and promotes the else statement to the if expression with the expression logic reversed. I feel this is more readable as the empty statement can lead to issues if any additional logic was ever added. Reviewed-by: Toshi Kani <toshi.kani@hpe.com> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers')
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index bb813b8e8ace..43bad0d5bdb6 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
@@ -261,9 +261,8 @@ int nd_label_validate(struct nvdimm_drvdata *ndd)
void nd_label_copy(struct nvdimm_drvdata *ndd, struct nd_namespace_index *dst,
struct nd_namespace_index *src)
- if (dst && src)
- /* pass */;
- else
+ /* just exit if either destination or source is NULL */
+ if (!dst || !src)
memcpy(dst, src, sizeof_namespace_index(ndd));

Privacy Policy