path: root/drivers
diff options
authorHans Verkuil <hverkuil@xs4all.nl>2018-10-15 06:14:22 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2018-10-15 09:57:52 -0400
commit490d84f6d73c12f4204241cff8651eed60aae914 (patch)
tree2e90dfab1ce66bd12cfaab752d15eb0dbf311de8 /drivers
parent8caec72e8cbff65afa38928197bea5a393b67975 (diff)
media: cec: forgot to cancel delayed work
If the wait for completion was interrupted, then make sure to cancel any delayed work. This can only happen if a transmit is waiting for a reply, and you press Ctrl-C or reboot/poweroff or something like that which interrupts the thread waiting for the reply and then proceeds to delete the CEC message. Since the delayed work wasn't canceled, once it would trigger it referred to stale data and resulted in a kernel oops. Fixes: 7ec2b3b941a6 ("cec: add new tx/rx status bits to detect aborts/timeouts") Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: <stable@vger.kernel.org> # for v4.18 and up Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers')
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/cec/cec-adap.c b/drivers/media/cec/cec-adap.c
index 0c0d9107383e..31d1f4ab915e 100644
--- a/drivers/media/cec/cec-adap.c
+++ b/drivers/media/cec/cec-adap.c
@@ -844,6 +844,8 @@ int cec_transmit_msg_fh(struct cec_adapter *adap, struct cec_msg *msg,
+ if (!data->completed)
+ cancel_delayed_work_sync(&data->work);
/* Cancel the transmit if it was interrupted */

Privacy Policy