path: root/net/compat.c
diff options
authorMiklos Szeredi <miklos@szeredi.hu>2006-10-09 21:42:14 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2006-10-11 23:59:48 -0700
commiteffee6a00034a8d83a6dea6d221820d87364ac21 (patch)
tree7008bcfd7f2c2ece8e58365ff970a90292b6af08 /net/compat.c
parent6aa2551cf135f1d246d31482adc8c679eeea3a83 (diff)
[NET]: File descriptor loss while receiving SCM_RIGHTS
If more than one file descriptor was sent with an SCM_RIGHTS message, and on the receiving end, after installing a nonzero (but not all) file descritpors the process runs out of fds, then the already installed fds will be lost (userspace will have no way of knowing about them). The following patch makes sure, that at least the already installed fds are sent to userspace. It doesn't solve the issue of losing file descriptors in case of an EFAULT on the userspace buffer. Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/compat.c')
1 files changed, 1 insertions, 2 deletions
diff --git a/net/compat.c b/net/compat.c
index d5d69fa15d07..52d32f1bc728 100644
--- a/net/compat.c
+++ b/net/compat.c
@@ -285,8 +285,7 @@ void scm_detach_fds_compat(struct msghdr *kmsg, struct scm_cookie *scm)
if (i > 0) {
int cmlen = CMSG_COMPAT_LEN(i * sizeof(int));
- if (!err)
- err = put_user(SOL_SOCKET, &cm->cmsg_level);
+ err = put_user(SOL_SOCKET, &cm->cmsg_level);
if (!err)
err = put_user(SCM_RIGHTS, &cm->cmsg_type);
if (!err)

Privacy Policy