aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorThomas Graf <tgraf@suug.ch>2015-04-30 22:37:42 +0000
committerDavid S. Miller <davem@davemloft.net>2015-05-03 23:08:54 -0400
commitc2c8a901660dcc647ffe5f6dcb1e4c500a5442aa (patch)
treec3587da63227bc63f281af80432df5b5de3576c0 /lib
parent1aa661f5c3df15432530f01f1023d556fa81b95d (diff)
rhashtable-test: Get rid of ptr in test_obj structure
This only blows up the size of the test structure for no gain in test coverage. Reduces size of test_obj from 24 to 16 bytes. Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
-rw-r--r--lib/test_rhashtable.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index e3d31bf527a9..d6d6719b61b7 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -22,7 +22,6 @@
#include <linux/slab.h>
-#define TEST_PTR ((void *) 0xdeadbeef)
#define MAX_ENTRIES 1000000
static int entries = 50000;
@@ -46,7 +45,6 @@ module_param(size, int, 0);
MODULE_PARM_DESC(size, "Initial size hint of table (default: 8)");
struct test_obj {
- void *ptr;
int value;
struct rhash_head node;
};
@@ -78,9 +76,9 @@ static int __init test_rht_lookup(struct rhashtable *ht)
key);
return -EEXIST;
} else if (expected && obj) {
- if (obj->ptr != TEST_PTR || obj->value != i) {
- pr_warn("Test failed: Lookup value mismatch %p!=%p, %u!=%u\n",
- obj->ptr, TEST_PTR, obj->value, i);
+ if (obj->value != i) {
+ pr_warn("Test failed: Lookup value mismatch %u!=%u\n",
+ obj->value, i);
return -EINVAL;
}
}
@@ -153,7 +151,6 @@ static s64 __init test_rhashtable(struct rhashtable *ht)
goto error;
}
- obj->ptr = TEST_PTR;
obj->value = i * 2;
err = rhashtable_insert_fast(ht, &obj->node, test_rht_params);

Privacy Policy