path: root/net/batman-adv/icmp_socket.h
diff options
authorSven Eckelmann <sven@narfation.org>2015-04-17 17:40:28 (GMT)
committerAntonio Quartulli <antonio@meshcoding.com>2015-06-07 15:07:19 (GMT)
commit1e2c2a4fe4a52cc55a78727778119f9a74283b8a (patch)
treee8b5c204945baf2eab19a35d5f2ca3b555eaa75b /net/batman-adv/icmp_socket.h
parentbcef1f3c49daee2829cf58e30310427c63038cff (diff)
batman-adv: Add required includes to all files
The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Diffstat (limited to 'net/batman-adv/icmp_socket.h')
1 files changed, 7 insertions, 0 deletions
diff --git a/net/batman-adv/icmp_socket.h b/net/batman-adv/icmp_socket.h
index 4815824..7de7fce 100644
--- a/net/batman-adv/icmp_socket.h
+++ b/net/batman-adv/icmp_socket.h
@@ -18,6 +18,13 @@
+#include "main.h"
+#include <linux/types.h>
+struct batadv_icmp_header;
+struct batadv_priv;
#define BATADV_ICMP_SOCKET "socket"
void batadv_socket_init(void);

Privacy Policy