path: root/net/ipv4/ip_forward.c
diff options
authorSebastian Pöhn <sebastian.poehn@gmail.com>2015-04-20 09:19:20 +0200
committerDavid S. Miller <davem@davemloft.net>2015-04-20 14:07:33 -0400
commit2ab957492d13bb819400ac29ae55911d50a82a13 (patch)
treeb89ecd5aae7568be9843525b174d90180d3166f3 /net/ipv4/ip_forward.c
parent04b7fe6a4a231871ef681bc95e08fe66992f7b1f (diff)
ip_forward: Drop frames with attached skb->sk
Initial discussion was: [FYI] xfrm: Don't lookup sk_policy for timewait sockets Forwarded frames should not have a socket attached. Especially tw sockets will lead to panics later-on in the stack. This was observed with TPROXY assigning a tw socket and broken policy routing (misconfigured). As a result frame enters forwarding path instead of input. We cannot solve this in TPROXY as it cannot know that policy routing is broken. v2: Remove useless comment Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_forward.c')
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c
index 939992c456f3..3674484946a5 100644
--- a/net/ipv4/ip_forward.c
+++ b/net/ipv4/ip_forward.c
@@ -82,6 +82,9 @@ int ip_forward(struct sk_buff *skb)
if (skb->pkt_type != PACKET_HOST)
goto drop;
+ if (unlikely(skb->sk))
+ goto drop;
if (skb_warn_if_lro(skb))
goto drop;

Privacy Policy