|author||Johannes Berg <firstname.lastname@example.org>||2009-06-02 13:01:37 +0200|
|committer||John W. Linville <email@example.com>||2009-06-03 14:06:13 -0400|
This patch completely rewrites the rfkill core to address the following deficiencies: * all rfkill drivers need to implement polling where necessary rather than having one central implementation * updating the rfkill state cannot be done from arbitrary contexts, forcing drivers to use schedule_work and requiring lots of code * rfkill drivers need to keep track of soft/hard blocked internally -- the core should do this * the rfkill API has many unexpected quirks, for example being asymmetric wrt. alloc/free and register/unregister * rfkill can call back into a driver from within a function the driver called -- this is prone to deadlocks and generally should be avoided * rfkill-input pointlessly is a separate module * drivers need to #ifdef rfkill functions (unless they want to depend on or select RFKILL) -- rfkill should provide inlines that do nothing if it isn't compiled in * the rfkill structure is not opaque -- drivers need to initialise it correctly (lots of sanity checking code required) -- instead force drivers to pass the right variables to rfkill_alloc() * the documentation is hard to read because it always assumes the reader is completely clueless and contains way TOO MANY CAPS * the rfkill code needlessly uses a lot of locks and atomic operations in locked sections * fix LED trigger to actually change the LED when the radio state changes -- this wasn't done before Tested-by: Alan Jenkins <firstname.lastname@example.org> Signed-off-by: Henrique de Moraes Holschuh <email@example.com> [thinkpad] Signed-off-by: Johannes Berg <firstname.lastname@example.org> Signed-off-by: John W. Linville <email@example.com>
Diffstat (limited to 'net/rfkill/Kconfig')
1 files changed, 7 insertions, 14 deletions
diff --git a/net/rfkill/Kconfig b/net/rfkill/Kconfig
index 7f807b30cfbb..b47f72fae05d 100644
@@ -10,22 +10,15 @@ menuconfig RFKILL
To compile this driver as a module, choose M here: the
module will be called rfkill.
- tristate "Input layer to RF switch connector"
- depends on RFKILL && INPUT
- Say Y here if you want kernel automatically toggle state
- of RF switches on and off when user presses appropriate
- button or a key on the keyboard. Without this module you
- need a some kind of userspace application to control
- state of the switches.
- To compile this driver as a module, choose M here: the
- module will be called rfkill-input.
# LED trigger support
- depends on RFKILL && LEDS_TRIGGERS
+ depends on RFKILL
+ depends on LEDS_TRIGGERS = y || RFKILL = LEDS_TRIGGERS
+ depends on RFKILL
+ depends on INPUT = y || RFKILL = INPUT
+ default y