diff options
authorAlex Elder <elder@inktank.com>2013-05-29 11:19:00 -0500
committerSage Weil <sage@inktank.com>2013-07-03 15:32:40 -0700
commit4974341eb99861720d54db9337bf1fe78eb8b9d0 (patch)
parent08f75463c15e26e9d67a7c992ce7dd8964c6cbdd (diff)
libceph: print more info for short message header
If an osd client response message arrives that has a front section that's too big for the buffer set aside to receive it, a warning gets reported and a new buffer is allocated. The warning says nothing about which connection had the problem. Add the peer type and number to what gets reported, to be a bit more informative. Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
1 files changed, 4 insertions, 2 deletions
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index e0abb83b520e..61147fe70181 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -2454,8 +2454,10 @@ static struct ceph_msg *get_reply(struct ceph_connection *con,
if (front > req->r_reply->front.iov_len) {
- pr_warning("get_reply front %d > preallocated %d\n",
- front, (int)req->r_reply->front.iov_len);
+ pr_warning("get_reply front %d > preallocated %d (%u#%llu)\n",
+ front, (int)req->r_reply->front.iov_len,
+ (unsigned int)con->peer_name.type,
+ le64_to_cpu(con->peer_name.num));
m = ceph_msg_new(CEPH_MSG_OSD_OPREPLY, front, GFP_NOFS, false);
if (!m)
goto out;

Privacy Policy