path: root/arch/powerpc/platforms
diff options
authorPreeti U Murthy <preeti@linux.vnet.ibm.com>2014-01-13 06:34:51 (GMT)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2014-01-15 02:58:56 (GMT)
commitc0c4301c54adde05fa3652777f550e4570b87399 (patch)
tree58040b49d1484795001e92e1f3d31a1dc4c3f4b6 /arch/powerpc/platforms
parent4f7709248db7402507a2a5164f86ad4c75a1926b (diff)
pseries/cpuidle: Remove redundant call to ppc64_runlatch_off() in cpu idle routines
Commit fbd7740fdfdf9475f(powerpc: Simplify pSeries idle loop) switched pseries cpu idle handling from complete idle loops to ppc_md.powersave functions. Earlier to this switch, ppc64_runlatch_off() had to be called in each of the idle routines. But after the switch, this call is handled in arch_cpu_idle(),just before the call to ppc_md.powersave, where platform specific idle routines are called. As a consequence, the call to ppc64_runlatch_off() got duplicated in the arch_cpu_idle() routine as well as in the some of the idle routines in pseries and commit fbd7740fdfdf9475f missed to get rid of these redundant calls. These calls were carried over subsequent enhancements to the pseries cpuidle routines. Although multiple calls to ppc64_runlatch_off() is harmless, there is still some overhead due to it. Besides that, these calls could also make way for a misunderstanding that it is *necessary* to call ppc64_runlatch_off() multiple times, when that is not the case. Hence this patch takes care of eliminating this redundancy. Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/platforms')
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/powerpc/platforms/pseries/processor_idle.c b/arch/powerpc/platforms/pseries/processor_idle.c
index a166e38..09e4f56 100644
--- a/arch/powerpc/platforms/pseries/processor_idle.c
+++ b/arch/powerpc/platforms/pseries/processor_idle.c
@@ -17,7 +17,6 @@
#include <asm/reg.h>
#include <asm/machdep.h>
#include <asm/firmware.h>
-#include <asm/runlatch.h>
#include <asm/plpar_wrappers.h>
struct cpuidle_driver pseries_idle_driver = {
@@ -63,7 +62,6 @@ static int snooze_loop(struct cpuidle_device *dev,
while ((!need_resched()) && cpu_online(cpu)) {
- ppc64_runlatch_off();
@@ -103,7 +101,6 @@ static int dedicated_cede_loop(struct cpuidle_device *dev,
get_lppaca()->donate_dedicated_cpu = 1;
- ppc64_runlatch_off();

Privacy Policy