path: root/net
diff options
authorBen Hutchings <bhutchings@solarflare.com>2012-07-30 15:57:44 +0000
committerDavid S. Miller <davem@davemloft.net>2012-08-02 00:19:17 -0700
commit7e6d06f0de3f74ca929441add094518ae332257c (patch)
tree94c11a47268450c5ba913eeba5c2f7a0e3780126 /net
parent30b678d844af3305cda5953467005cebb5d7b687 (diff)
sfc: Fix maximum number of TSO segments and minimum TX queue size
Currently an skb requiring TSO may not fit within a minimum-size TX queue. The TX queue selected for the skb may stall and trigger the TX watchdog repeatedly (since the problem skb will be retried after the TX reset). This issue is designated as CVE-2012-3412. Set the maximum number of TSO segments for our devices to 100. This should make no difference to behaviour unless the actual MSS is less than about 700. Increase the minimum TX queue size accordingly to allow for 2 worst-case skbs, so that there will definitely be space to add an skb after we wake a queue. To avoid invalidating existing configurations, change efx_ethtool_set_ringparam() to fix up values that are too small rather than returning -EINVAL. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions

Privacy Policy