aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Krufky <mkrufky@kernellabs.com>2011-09-08 04:17:39 (GMT)
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-09-09 18:28:04 (GMT)
commit2d04c13a507f5a01daa7422cd52250809573cfdb (patch)
tree965333495268c26193ee6f10a6b979ebe726d9a4
parent4b5d01e9f66446be0c2beebfab0463210bed315d (diff)
[media] dvb-usb: improve sanity check of adap->active_fe in dvb_usb_ctrl_feedstaging/for_v3.2
The check for (adap->active_fe < 0) at the top of dvb_usb_ctrl_feed is a sanity check to ensure that adap->active_fe is valid. Improve that sanity check by also checking for (adap->active_fe >= adap->num_frontends_initialized) Signed-off-by: Michael Krufky <mkrufky@kernellabs.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/dvb/dvb-usb/dvb-usb-dvb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-dvb.c b/drivers/media/dvb/dvb-usb/dvb-usb-dvb.c
index 460b5ae..038679b 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-dvb.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-dvb.c
@@ -17,7 +17,8 @@ static int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
if (adap == NULL)
return -ENODEV;
- if (adap->active_fe < 0) {
+ if ((adap->active_fe < 0) ||
+ (adap->active_fe >= adap->num_frontends_initialized)) {
return -EINVAL;
}

Privacy Policy