path: root/net
diff options
authorDan Carpenter <error27@gmail.com>2010-09-10 01:56:16 +0000
committerDavid S. Miller <davem@davemloft.net>2010-09-13 12:44:10 -0700
commit339db11b219f36cf7da61b390992d95bb6b7ba2e (patch)
tree38faf26336bb97d53dddf918d360914f709e2254 /net
parenta505b3b30fc69904f858822a2aa95990a4bf7958 (diff)
net/llc: make opt unsigned in llc_ui_setsockopt()
The members of struct llc_sock are unsigned so if we pass a negative value for "opt" it can cause a sign bug. Also it can cause an integer overflow when we multiply "opt * HZ". CC: stable@kernel.org Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
1 files changed, 2 insertions, 1 deletions
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index 023ba820236f..582612998211 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname,
struct sock *sk = sock->sk;
struct llc_sock *llc = llc_sk(sk);
- int rc = -EINVAL, opt;
+ unsigned int opt;
+ int rc = -EINVAL;
if (unlikely(level != SOL_LLC || optlen != sizeof(int)))

Privacy Policy