aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTuomas Tynkkynen <ttynkkynen@nvidia.com>2013-07-25 19:24:09 (GMT)
committerFelipe Balbi <balbi@ti.com>2013-07-29 12:19:19 (GMT)
commita554aea67aaadb7f3396b2a8f940ab0b915b2a5e (patch)
tree42fcf64fc8a1d2317153f3c026ef5e0fffde73f2
parent9be73bae70ac5b0149daa243eeae2bdacd970574 (diff)
usb: phy: tegra: Use switch instead of if-else
Use switch() instead of if-else when checking for the PHY type. Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/phy/phy-tegra-usb.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 01c30ff..49fa2da 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -887,11 +887,14 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
of_property_read_bool(np, "nvidia,has-legacy-mode");
phy_type = of_usb_get_phy_mode(np);
- if (phy_type == USBPHY_INTERFACE_MODE_UTMI) {
+ switch (phy_type) {
+ case USBPHY_INTERFACE_MODE_UTMI:
err = utmi_phy_probe(tegra_phy, pdev);
if (err < 0)
return err;
- } else if (phy_type == USBPHY_INTERFACE_MODE_ULPI) {
+ break;
+
+ case USBPHY_INTERFACE_MODE_ULPI:
tegra_phy->is_ulpi_phy = true;
tegra_phy->reset_gpio =
@@ -902,7 +905,9 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
return tegra_phy->reset_gpio;
}
tegra_phy->config = NULL;
- } else {
+ break;
+
+ default:
dev_err(&pdev->dev, "phy_type is invalid or unsupported\n");
return -EINVAL;
}

Privacy Policy