aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/dvb-frontends/si2168.c
diff options
context:
space:
mode:
authorAntti Palosaari <crope@iki.fi>2014-12-05 17:30:44 (GMT)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-01-29 20:41:11 (GMT)
commit4affbe1d0825dc3c9c5fcec8a4848d8bbdd718cb (patch)
treef428591902da5d392758588be91dfc5ab111d630 /drivers/media/dvb-frontends/si2168.c
parent3de3583539390a6e0d5b780f0c16980462991f7c (diff)
[media] si2168: simplify si2168_cmd_execute() error path
Remove if () from firmware command error path as there should not be any error prone conditional logic there. Use goto labels instead. Signed-off-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/dvb-frontends/si2168.c')
-rw-r--r--drivers/media/dvb-frontends/si2168.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index e00bc04..3c102e5 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -66,15 +66,11 @@ static int si2168_cmd_execute(struct i2c_client *client, struct si2168_cmd *cmd)
}
}
- ret = 0;
+ mutex_unlock(&dev->i2c_mutex);
+ return 0;
err_mutex_unlock:
mutex_unlock(&dev->i2c_mutex);
- if (ret)
- goto err;
-
- return 0;
-err:
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;
}

Privacy Policy