path: root/drivers/media/pci
diff options
authorHans Verkuil <hans.verkuil@cisco.com>2014-12-08 16:23:50 (GMT)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2014-12-17 01:21:40 (GMT)
commit389208e1173e097590856ed24a505551510f78d4 (patch)
tree2225b7569a3fa1646b9697e7c44f0ec8f620fe3d /drivers/media/pci
parent165d00439fa9e9da7f263dc844cbd524cf624074 (diff)
[media] cx88: remove leftover start_video_dma() call
The start_streaming op is responsible for starting the video dma, so it shouldn't be called anymore from the buf_queue op. Unfortunately, this call to start_video_dma() was added to the start_streaming op, but was forgotten to be removed from the buf_queue op, which is where it used to be before the vb2 conversion. Calling this function twice causes very hard to find errors: sometimes it works, sometimes it doesn't. It took me a whole friggin' day to track this down, and in the end it was just luck that my eye suddenly triggered on that line. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/pci')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/pci/cx88/cx88-video.c b/drivers/media/pci/cx88/cx88-video.c
index 25a4b7f31..860c98fc 100644
--- a/drivers/media/pci/cx88/cx88-video.c
+++ b/drivers/media/pci/cx88/cx88-video.c
@@ -523,7 +523,6 @@ static void buffer_queue(struct vb2_buffer *vb)
if (list_empty(&q->active)) {
list_add_tail(&buf->list, &q->active);
- start_video_dma(dev, q, buf);
buf->count = q->count++;
dprintk(2,"[%p/%d] buffer_queue - first active\n",
buf, buf->vb.v4l2_buf.index);

Privacy Policy