diff options
authorGuojia Liao <liaoguojia@huawei.com>2021-08-30 21:51:07 +0800
committerDavid S. Miller <davem@davemloft.net>2021-08-31 12:36:42 +0100
commite79c0e324b011b0288cd411a5b53870a7730f163 (patch)
parentdc9b5ce03124cf86bac3bd714369a8387d6e2012 (diff)
net: hns3: clean up a type mismatch warning
abs() returns signed long, which could not convert the type as unsigned, and it may cause a mismatch type warning from static tools. To fix it, this patch uses an variable to save the abs()'s result and does a explicit conversion. Signed-off-by: Guojia Liao <liaoguojia@huawei.com> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
index 0315d8312af3..2ce5302c5956 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
@@ -10,7 +10,14 @@
static u16 hclge_errno_to_resp(int errno)
- return abs(errno);
+ int resp = abs(errno);
+ /* The status for pf to vf msg cmd is u16, constrainted by HW.
+ * We need to keep the same type with it.
+ * The intput errno is the stander error code, it's safely to
+ * use a u16 to store the abs(errno).
+ */
+ return (u16)resp;
/* hclge_gen_resp_to_vf: used to generate a synchronous response to VF when PF

Privacy Policy