diff options
authorArseny Maslennikov <ar@cs.msu.ru>2019-03-09 15:43:06 (GMT)
committerMasahiro Yamada <yamada.masahiro@socionext.com>2019-03-17 03:56:23 (GMT)
commitf6d9db6355227656108cb93dd8c74d9a9904c5fb (patch)
parentda9cfb87a44da61f2403c4312916befcb6b6d7e8 (diff)
kbuild: deb-pkg: avoid implicit effects
* The man page for dpkg-source(1) notes: > -b, --build directory [format-specific-parameters] > Build a source package (--build since dpkg 1.17.14). > <...> > > dpkg-source will build the source package with the first > format found in this ordered list: the format indicated > with the --format command line option, the format > indicated in debian/source/format, “1.0”. The fallback > to “1.0” is deprecated and will be removed at some point > in the future, you should always document the desired > source format in debian/source/format. See section > SOURCE PACKAGE FORMATS for an extensive description of > the various source package formats. Thus it would be more foolproof to explicitly use 1.0 (as we always did) than to rely on dpkg-source's defaults. * In a similar vein, debian/rules is not made executable by mkdebian, and dpkg-source warns about that but still silently fixes the file. Let's be explicit once again. Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
1 files changed, 4 insertions, 1 deletions
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index 8068328..8351584 100755
--- a/scripts/package/mkdebian
+++ b/scripts/package/mkdebian
@@ -132,7 +132,9 @@ else
echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST explicitly"
-mkdir -p debian/
+mkdir -p debian/source/
+echo "1.0" > debian/source/format
echo $debarch > debian/arch
extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev)"
extra_build_depends="$extra_build_depends, $(if_enabled_echo CONFIG_SYSTEM_TRUSTED_KEYRING libssl-dev:native)"
@@ -223,5 +225,6 @@ clean:
binary: binary-arch
+chmod +x debian/rules
exit 0

Privacy Policy