path: root/arch/s390/include
diff options
authorKees Cook <keescook@chromium.org>2020-01-08 10:06:54 -0800
committerKees Cook <keescook@chromium.org>2020-01-08 17:05:45 -0800
commite163fdb3f7f8c62dccf194f3f37a7bcb3c333aa8 (patch)
tree55fd934daa0d7389213d6bcf7b6df94e73e1a03d /arch/s390/include
parent9e5f1c19800b808a37fb9815a26d382132c26c3d (diff)
pstore/ram: Regularize prz label allocation lifetime
In my attempt to fix a memory leak, I introduced a double-free in the pstore error path. Instead of trying to manage the allocation lifetime between persistent_ram_new() and its callers, adjust the logic so persistent_ram_new() always takes a kstrdup() copy, and leaves the caller's allocation lifetime up to the caller. Therefore callers are _always_ responsible for freeing their label. Before, it only needed freeing when the prz itself failed to allocate, and not in any of the other prz failure cases, which callers would have no visibility into, which is the root design problem that lead to both the leak and now double-free bugs. Reported-by: Cengiz Can <cengiz@kernel.wtf> Link: https://lore.kernel.org/lkml/d4ec59002ede4aaf9928c7f7526da87c@kernel.wtf Fixes: 8df955a32a73 ("pstore/ram: Fix error-path memory leak in persistent_ram_new() callers") Cc: stable@vger.kernel.org Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'arch/s390/include')
0 files changed, 0 insertions, 0 deletions

Privacy Policy