path: root/drivers/media/i2c/smiapp/smiapp-core.c
diff options
authorSakari Ailus <sakari.ailus@linux.intel.com>2017-08-29 09:41:23 -0300
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2017-10-04 17:24:11 -0300
commitf689866aec08f00efc4a098d14b3a17ec8a9193b (patch)
tree787de1cea40e5311c52b96afaa637de0d7a063bb /drivers/media/i2c/smiapp/smiapp-core.c
parentd339ec6a4261c030d8fdea75625c925f33549a2e (diff)
[media] smiapp: Verify clock frequency after setting it, prevent changing it
The external clock frequency was set by the driver but the obtained frequency was never verified. Do that. Being able to obtain the exact frequency is important as the value is used for PLL calculations which may result in frequencies that violate the PLL tree limits. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/i2c/smiapp/smiapp-core.c')
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index d581625d7826..55771826b446 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -2870,6 +2870,7 @@ static int smiapp_probe(struct i2c_client *client,
struct smiapp_sensor *sensor;
struct smiapp_hwconfig *hwcfg = smiapp_get_hwconfig(&client->dev);
+ unsigned long rate;
unsigned int i;
int rval;
@@ -2908,6 +2909,14 @@ static int smiapp_probe(struct i2c_client *client,
return rval;
+ rate = clk_get_rate(sensor->ext_clk);
+ if (rate != sensor->hwcfg->ext_clk) {
+ dev_err(&client->dev,
+ "can't set clock freq, asked for %u but got %lu\n",
+ sensor->hwcfg->ext_clk, rate);
+ return rval;
+ }
sensor->xshutdown = devm_gpiod_get_optional(&client->dev, "xshutdown",
if (IS_ERR(sensor->xshutdown))

Privacy Policy