path: root/kernel
diff options
authorSteven Rostedt (VMware) <rostedt@goodmis.org>2019-12-11 15:44:22 -0500
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2019-12-19 18:26:00 -0500
commit106f41f5a302cb1f36c7543fae6a05de12e96fa4 (patch)
treec3b4c17919575dd2ad393048409cb142ce435115 /kernel
parent79e65c27f09683fbb50c33acab395d0ddf5302d2 (diff)
tracing: Have the histogram compare functions convert to u64 first
The compare functions of the histogram code would be specific for the size of the value being compared (byte, short, int, long long). It would reference the value from the array via the type of the compare, but the value was stored in a 64 bit number. This is fine for little endian machines, but for big endian machines, it would end up comparing zeros or all ones (depending on the sign) for anything but 64 bit numbers. To fix this, first derference the value as a u64 then convert it to the type being compared. Link: http://lkml.kernel.org/r/20191211103557.7bed6928@gandalf.local.home Cc: stable@vger.kernel.org Fixes: 08d43a5fa063e ("tracing: Add lock-free tracing_map") Acked-by: Tom Zanussi <zanussi@kernel.org> Reported-by: Sven Schnelle <svens@stackframe.org> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'kernel')
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/trace/tracing_map.c b/kernel/trace/tracing_map.c
index 9a1c22310323..9e31bfc818ff 100644
--- a/kernel/trace/tracing_map.c
+++ b/kernel/trace/tracing_map.c
@@ -148,8 +148,8 @@ static int tracing_map_cmp_atomic64(void *val_a, void *val_b)
static int tracing_map_cmp_##type(void *val_a, void *val_b) \
{ \
- type a = *(type *)val_a; \
- type b = *(type *)val_b; \
+ type a = (type)(*(u64 *)val_a); \
+ type b = (type)(*(u64 *)val_b); \
return (a > b) ? 1 : ((a < b) ? -1 : 0); \

Privacy Policy