path: root/net
diff options
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>2018-12-30 14:33:20 +0200
committerDavid S. Miller <davem@davemloft.net>2018-12-30 11:35:36 -0800
commitf989d03ef25df3fc26d3ea0fe7c19c9830577166 (patch)
tree949313d43808a2f758ea52cf82c072e6988f2769 /net
parentf7d18ef6a95f399544d7b767291980cecddc32eb (diff)
net: rtnetlink: address is mandatory for rtnl_fdb_get
We must have an address to lookup otherwise we'll derefence a null pointer in the ndo_fdb_get callbacks. CC: Roopa Prabhu <roopa@cumulusnetworks.com> CC: David Ahern <dsa@cumulusnetworks.com> Reported-by: syzbot+017b1f61c82a1c3e7efd@syzkaller.appspotmail.com Fixes: 5b2f94b27622 ("net: rtnetlink: support for fdb get") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
1 files changed, 5 insertions, 0 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 48f61885fd6f..5ea1bed08ede 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4104,6 +4104,11 @@ static int rtnl_fdb_get(struct sk_buff *in_skb, struct nlmsghdr *nlh,
if (err < 0)
return err;
+ if (!addr) {
+ NL_SET_ERR_MSG(extack, "Missing lookup address for fdb get request");
+ return -EINVAL;
+ }
if (brport_idx) {
dev = __dev_get_by_index(net, brport_idx);
if (!dev) {

Privacy Policy