aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-03-17libdvbv5: leaks and double free in dvb_fe_open_fname()HEADmasterSean Young2-11/+9
dvb_fe_open_fname() takes ownership of fname if the function succeeds, but also in two of the error paths (e.g. if the ioctl FE_GET_PROPERTY fails). Adjust dvb_fe_open_fname() so it copies fname rather than taking ownership (and passing that to params). This makes the code cleaner. Signed-off-by: Sean Young <sean@mess.org>
2019-03-17lircd2toml: convert lircd.conf rc6 remote definitionsSean Young1-1/+62
Signed-off-by: Sean Young <sean@mess.org>
2019-03-17dvbv5-zap: improve program exit codeMauro Carvalho Chehab1-4/+22
While testing the program with Valgrind, it would keep reporting about non-freed data. The main reason is that, when called in non-record and non-monitor mode, the while() loop doesn't check for the timeout indication. Solve that and be sure that all strdup() vars will be freed too. On my tests, on normal mode, on monitor mode and on record mode, it now shows no memory leaks with Valgrind. Having zero leaks in Valgrind is important mostly because we don't want the libraries to leak. Having all memory allocated internally at the program freed means that, if Valgrind will report any memory leaks in the future, it would belong to the library code. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
2019-03-14dvbv5-tools: be sure to zero struct argumentsMauro Carvalho Chehab3-3/+3
Let's not let the arguments struct with some random value. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
2019-03-13lircd2toml: detect NEC if bit 0 and 1 are invertedSean Young1-0/+36
This fixes conversion of: http://lirc.sourceforge.net/remotes/goldstar/VCR Signed-off-by: Sean Young <sean@mess.org>
2019-03-13lircd2toml: honour pre_data for rc-mm remote definitionsSean Young1-7/+15
Signed-off-by: Sean Young <sean@mess.org>
2019-03-13v4l2-ctl: set the in/out fmt variables in streaming_set_m2mDafna Hirschfeld1-10/+11
set the in/out fmt variables in streaming_set_m2m This is needed later to check for stateless fwht pixel format. Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-13v4l2-ctl: check that the size read/write fit the buffer sizeDafna Hirschfeld1-17/+24
'read_write_padded_frame' should check that the expected size to read/write is not larger than the size of the buffer. Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-13v4l2-ctl: in streaming_set_m2m, close file pointers upon errorDafna Hirschfeld1-3/+4
In streaming_set_m2m, make sure to close all file pointers and file descriptors before returning. Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-13v4l2-ctl: improve logging of events and the stop en/decoder cmds.Hans Verkuil1-3/+4
Added a few missing newlines and log when the en/decoder is stopped. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-13v4l2-ctl: show timestamp flags as well in print_concise_bufferHans Verkuil1-0/+2
The concise buffer info didn't include the timestamp flags, which was confusing. So just show them. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-13v4l2-info.cpp: fix bufferflags2s: could end with ', 'Hans Verkuil1-12/+17
If after clearing the timestamp-related flags the value was 0, then the string would end with ", ". That is ugly, so rework the code. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-13lircd2toml: toggle_bit is offset from bits including pre-dataSean Young1-6/+6
This causes the following lircd.conf to be converted incorrectly. http://lirc.sourceforge.net/remotes/cambridge_audio/X40A Signed-off-by: Sean Young <sean@mess.org>
2019-03-12v4l2-ctl: show cap/out in print_concise_buffer()Hans Verkuil1-1/+2
print_concise_buffer() shows buffer information, but not whether it was a capture or output buffer. This is confusing when dealing with m2m devices, so add a 'cap' or 'out' prefix. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-12v4l2-ctl: improve selection outputHans Verkuil1-3/+2
Don't show crop info when using --all, only show the selection info (crop doesn't add any useful information). Also show the buffer type for which the selection info is shown. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-11libv4lconvert: add support for BAYER16Daniel Gomez3-0/+57
Add support for 16 bit Bayer formats: -V4L2_PIX_FMT_SBGGR16 -V4L2_PIX_FMT_SGBRG16 -V4L2_PIX_FMT_SGRBG16 -V4L2_PIX_FMT_SRGGB16 Tested using vivid included in linux v5.0-rc8. Signed-off-by: Daniel Gomez <daniel@qtec.com> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-11libv4lconvert: add support for BAYER10Daniel Gomez3-18/+59
Add support for 10 bit Bayer formats: -V4L2_PIX_FMT_SBGGR10 -V4L2_PIX_FMT_SGBRG10 -V4L2_PIX_FMT_SRGGB10 Previous BAYER10 format declared (V4L2_PIX_FMT_SGRBG10) now is grouped with the new list without the need of tmp buffer. Update v4lconvert_10to8 function: - Renaming function name to keep naming convention with the other bayer10p conversion function: v4lconvert_10to8 -> v4lconvert_bayer10_to_bayer8 Tested using vivid included in linux v5.0-rc8. Signed-off-by: Daniel Gomez <daniel@qtec.com> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-11jpgl.c: fix typoHans Verkuil1-1/+1
make -> makes Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-11v4l-utils: then -> thanHans Verkuil13-20/+20
Fix lots of places where 'than' instead of 'then' should be used. Reported-by: Jason H <jhihn@gmx.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-09keytable: Add man page describing rc_keymap toml fileSean Young7-3/+306
Signed-off-by: Sean Young <sean@mess.org>
2019-03-08v4l2-compliance: fix check for entity namesHans Verkuil1-3/+20
sizeof(name) is 64 for media_v2_entity but 32 for struct media_entity_desc. So only consider the first 32 bytes (31 characters) for the duplicate name tests and matching what ENUM_ENTITIES reports with what G_TOPOLOGY reports. Also relax the check of the possible interface types to allow alsa as this is upcoming with the Media Device Allocator API. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
2019-03-08test-media: improve vimc configuration and add more unbind testsHans Verkuil1-3/+24
There were compliance failures when testing vimc due to a wrong setup for Raw Capture 1. That is now fixed. Tests have also been added were the subdevs are unbound before the main vimc driver. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-05ir-ctl: various typosSean Young3-4/+4
Signed-off-by: Sean Young <sean@mess.org>
2019-03-05test-media: rmmod all vimc modulesHans Verkuil1-1/+1
The vimc driver consists of multiple modules, but rmmod only unloaded the vimc module. Add all vimc modules to the rmmod line. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-05test-media: randomize sleep valuesHans Verkuil1-5/+11
Use random sleep values so device nodes are closed in a different order for each test. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-05test-media: replace v4l2-ctl --sleep by sleepHans Verkuil1-3/+3
Just use sleep directly. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-05v4l2-ctl: also list media device with --list-devicesHans Verkuil1-2/+4
When combining -z with --list-devices all devices belonging to the given platform device are shown, except for the media device itself. Show the media device as well. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-01test-media: open devices before second unbind.Hans Verkuil1-3/+20
This helps test the case where you unbind the device while the device nodes are still open. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-03-01v4l2-ctl: --list-devices can now be combined with -zHans Verkuil4-6/+76
Using '-z media-bus-info --list-devices' will show all devices as specified in the media topology of the media device with the given bus info. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-27test-media: add 'date' commandsHans Verkuil1-0/+9
Add 'date' commands to show how long each step takes. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-26v4l2-ctl: remove unused labelHans Verkuil1-1/+1
Drop the label to fix the gcc warning. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-25v4l2-ctl: move stateful m2m decode code to a separate functionDafna Hirschfeld1-45/+50
Add the function stateful_m2m that implements the stateful codec api. This is a preparation for having both stateful and stateless implementations Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-25v4l2-ctl: test if do_setup_out_buffers returns -1 instead of non zeroDafna Hirschfeld1-3/+3
If 'do_setup_out_buffers' returns -2 it means that it finished queuing all output stream buffers and the program should not terminate in that case. Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-25v4l2-ctl: bugfix: correctly read/write V4L2_PIX_FMT_NV24 padded bufferDafna Hirschfeld1-5/+13
For V4L2_PIX_FMT_NV24/42 types the chroma stride is twice the luma stride. Add support for it in 'read_write_padded_frame' Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-25v4l2-ctl: rename variable 'vic_fmt' to 'info'Dafna Hirschfeld1-7/+7
This is a better name for 'v4l2_fwht_pixfmt_info' type and it is not confused with 'cv4l_fmt' type. Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-25v4l2-compliance: enable epoll testHans Verkuil1-4/+3
The epoll support in V4L2 has now been fixed, so enable the epoll checks in v4l2-compliance. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-25cec-compliance: fix audio output delay checkHans Verkuil1-2/+4
The check for invalid audio output delay values should only take place if the audio output is partially compensated by the TV. Only if that's true is the audio output delay value used. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-21ir-ctl/keytable: rc-mm protocol supportSean Young4-3/+9
Signed-off-by: Sean Young <sean@mess.org>
2019-02-21ir-ctl/keytable: add see also to reference to man pagesSean Young2-0/+12
Add hint to how you can start to figure out what protocol a remote uses. Signed-off-by: Sean Young <sean@mess.org>
2019-02-21test-media: fix DEBUG_KOBJECT_RELEASE detection, test rebindHans Verkuil1-40/+84
The detection of CONFIG_DEBUG_KOBJECT_RELEASE=y was flawed, improve this. Also test rebind after unbinding. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-20test-media: add sleeps after configuring CECHans Verkuil1-0/+2
Add a sleep 1 after configuring each vivid CEC adapter to give it time to settle. Without sleeps this can hit a limitation of the vivid CEC emulation where transmits can repeatedly fail with the ARB_LOST error and as a result it picks Playback Device 2 instead of 1, causing the remainder of the CEC tests to fail. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-20test-media: remove '-s' from cec-ctl commandsHans Verkuil1-2/+2
Drop the -s option from the cec-ctl commands that configure the vivid cec adapters. It is important to see how they are configured. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-19cec-ctl: add a new --stress-test-power-cycle optionHans Verkuil2-0/+103
This option performs a stress test for a display, repeatedly turning the display on and off using CEC commands. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-19v4l2 utils: support V4L2_PIX_FMT_AYUV32 et alHans Verkuil7-15/+96
Add support for all four variants of V4L2_PIX_FMT_AYUV32 in the v4l2-ctl, v4l2-compliance, qvidcap and qv4l2 utilities. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-19v4l-utils: sync with media masterHans Verkuil8-3/+40
Synchronize with the latest headers from the media master tree. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-19cec-compliance: show latencies in ms and check valuesHans Verkuil1-2/+4
Show the audio/video latencies in ms as well, and check that the reported values are not using reserved values. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-19cec-ctl: fix transmitting broadcast commandsHans Verkuil1-1/+2
If a broadcast command was transmitted, but there was no --to option before that broadcast command option, then the 'from' value was 0xf and the transmit was rejected. Fix this by always clearing the top 4 bits before writing the initiator. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-19cec-ctl: show/parse latency in msHans Verkuil2-1/+20
The audio/video latency values are now logged in ms as well, and it is also possible to provide the value by adding the 'ms' suffix to the latency value. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-18test-media: replace rmmod by separate unbind and rmmodHans Verkuil1-20/+62
If kobjects are delayed-released, then when using rmmod the module memory can be freed before the kobject release function is called, which might be in that freed memory. As far as I can tell there is no protection for this, and so errors due to this are not a bug in the driver, but a consequence of enabling this debug option. So use unbind to check for issues with delayed release. And run rmmod once all those objects are safely released. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2019-02-17test-media: use the new -P (no progress) optionHans Verkuil1-4/+4
The progress messages from v4l2-compliance using \r were annoying. Use the -P option to prevent them. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Privacy Policy